refactor(core): use atob and btoa instead of Buffer#72
Open
andrascodes wants to merge 1 commit intocore_expose_stampersfrom
Open
refactor(core): use atob and btoa instead of Buffer#72andrascodes wants to merge 1 commit intocore_expose_stampersfrom
andrascodes wants to merge 1 commit intocore_expose_stampersfrom
Conversation
This was referenced Apr 1, 2026
andrascodes
force-pushed
the
andras/refactor-core-use-atob-and-btoa-instead-of-buffer
branch
from
ebacb9a to
da2f27c
Compare
andrascodes
force-pushed
the
core_expose_stampers
branch
from
54fa0c4 to
1800c58
Compare
andrascodes
force-pushed
the
andras/refactor-core-use-atob-and-btoa-instead-of-buffer
branch
from
da2f27c to
f3577ac
Compare
This was referenced Apr 1, 2026
andrascodes
force-pushed
the
core_expose_stampers
branch
from
1800c58 to
7c1df70
Compare
andrascodes
force-pushed
the
andras/refactor-core-use-atob-and-btoa-instead-of-buffer
branch
2 times, most recently
from
4a78517 to
068598d
Compare
OmarBasem
reviewed
Apr 8, 2026
Author
Yes. No Buffer in Hermes. Do you have a better alternative solution for this? I'd be happy to change it. |
andrascodes
force-pushed
the
andras/refactor-core-use-atob-and-btoa-instead-of-buffer
branch
from
068598d to
c1d3e47
Compare
andrascodes
force-pushed
the
core_expose_stampers
branch
from
892cc8f to
3819862
Compare
andrascodes
force-pushed
the
core_expose_stampers
branch
from
3819862 to
f3b5f87
Compare
andrascodes
force-pushed
the
andras/refactor-core-use-atob-and-btoa-instead-of-buffer
branch
from
c1d3e47 to
746cf47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #71. This PR is part of a stack created with Aviator.
mainCloses FS-1926
Removing the usage of Buffer and switching to
atobandbtoa+ using custom code. It works but this is probably best to replace with something more robust.